[CLOSED] Updates to add Croatian language

[core-ai-bot]

Issue by redmunds
Friday Apr 18, 2014 at 23:00 GMT
Originally opened as adobe/brackets#7567

---

Updates to add Croatian language from diomed.

This started with adobe/brackets#7504 and adobe/brackets#7515, so I merged those PRs here. There are also a few more changes from https://github.com/diomed/brackets.

---

redmunds included the following code: https://github.com/adobe/brackets/pull/7567/commits

[core-ai-bot]

Comment by redmunds
Saturday Apr 19, 2014 at 00:59 GMT

---

@RaymondLim Could you take a look at this PR and see if you can figure out why this language isn't working? Thanks.

cc@diomed

[core-ai-bot]

Comment by RaymondLim
Saturday Apr 19, 2014 at 02:47 GMT

---

@redmunds You need to add "hr": true in module.exports in src/nls/strings.js.

[core-ai-bot]

Comment by redmunds
Saturday Apr 19, 2014 at 16:32 GMT

---

@RaymondLim

You need to add "hr": true in module.exports in src/nls/strings.js.

Yes, that was it. There are so many "strings.js" files that I looked at the wrong one for that step. Thanks.

@diomed This now works. This comment mentions a few more strings to review.

[core-ai-bot]

Comment by redmunds
Saturday Apr 19, 2014 at 23:34 GMT

---

@diomed I notice a few more strings in the strings.js file need to be translated:

    "FILE_FILTER_DIALOG"                : "Edit Filter",
    "FILE_FILTER_INSTRUCTIONS"          : "Exclude files and folders matching any of the following strings / substrings or <a href='{0}' title='{0}'>globs</a>. Enter each string on a new line.",

Also, the last 2 words of this long one:

    "BEZIER_EDITOR_INFO"                        : "<kbd>↑</kbd><kbd>↓</kbd><kbd>←</kbd><kbd>→</kbd> Pomakni odabranu point*<br><kbd class='text'>Shift</kbd> Pomakni za 10 jedinica<br><kbd class='text'>Tab</kbd> Switch points",

[core-ai-bot]

Comment by TomMalbran
Saturday Apr 19, 2014 at 23:57 GMT

---

@redmunds You also need to add "hr": true in module.exports in src/nls/urls.js for the urls to work.

[core-ai-bot]

Comment by redmunds
Sunday Apr 20, 2014 at 00:28 GMT

---

@TomMalbran

You also need to add "hr": true in module.exports in src/nls/urls.js

Done. Thanks.

cc@diomed

[core-ai-bot]

Comment by diomed
Sunday Apr 20, 2014 at 22:01 GMT

---

I've updated strings.js with some of requested strings, and updated some of existing strings with new name, because I did not properly translate previous one.

However, I'm unsure of this:

1. "ERROR_TIMINGQUICKEDIT_INVALIDSYNTAX" : "Quick CSS Timing Function editing",

Timing Function - what is that, what does it do - can someone explain it to me, so I could translate it properly?.

[core-ai-bot]

Comment by redmunds
Monday Apr 21, 2014 at 15:00 GMT

---

Paste this css rule in a style sheet:

.test {
    transition-timing-function: cubic-bezier(.62, 0, 1, .98);
    transition-timing-function: steps(6, start);
}

Put cursor in each line and press Ctrl/Cmd-E to invoke the timing function editors for each of those functions.

[core-ai-bot]

Comment by diomed
Monday Apr 21, 2014 at 16:25 GMT

---

I've checked my CSS book and translated as it says.
Now, is there anything else I should translate ,or is that it?

[core-ai-bot]

Comment by redmunds
Monday Apr 21, 2014 at 22:44 GMT

---

Looks good. Merging.

[core-ai-bot]

Comment by diomed
Wednesday Apr 30, 2014 at 10:29 GMT

---

Hi! I'm not sure do you still receive my updated or not, so I'm just writing here to let you know that I've changed a few strings; 1 was untranslated, and other ones were not grammatically correct, so I've fixed them too.

[core-ai-bot]

Comment by redmunds
Wednesday Apr 30, 2014 at 15:15 GMT

---

@diomed I think that I merged all of your strings into the brackets master branch on April 21st in this commit -- take a look and see what's there. I have not merged any of your changes since then. You need to submit a pull request each time you have additional changes.

Note that I researched using transifex.com for Brackets, but they currently do not support the requirejs i18n system that we use. Let them know to add support for it!