[CLOSED] Extension Manager updates badge isn't clickable

[core-ai-bot]

Issue by cheesypoof
Friday Mar 21, 2014 at 07:33 GMT
Originally opened as adobe/brackets#7280

---

I think the extension update notification <span/> that is positioned over the "Installed" tab should be placed inside of the tab <a/>. This way when it is hovered or clicked, it is the tab that is interacted with and not the <span/>. See for example the current behavior when hovered - not what one might expect:

I'd like to tackle this as a starter bug if there is agreement that it should be changed.

What are Adobe's privacy policies in regards to the information supplied when signing the Brackets Contributor License Agreement? Under what circumstances could this information be provided to a third party? Thanks!

[core-ai-bot]

Comment by JeffryBooher
Friday Mar 21, 2014 at 08:34 GMT

---

Hi@cheesypoof -- Your information isn't shared with anyone -- it's essentially an agreement between you and Adobe. By signing the CLA, you grant Adobe and its Licensors unrestricted use of the contributions you make to Brackets and that you agree not to submit copyrighted materials, etc... The work you submit must be yours and yours alone. There are some exceptions, however. Like for instance, if you need to use a 3rd party library or node module to help write a feature or need it for an extension. The only thing we require is that the library or node module has an MIT license.

As for making the change, sure. Go ahead play around with it. When you have it working, put up a pull request and we'll play around with it and let you know what we think.@larz0 will evaluate the User Experience since he's the Brackets experience designer but it sounds like it will be fine.

Thanks for contributing to Brackets and welcome to the team!

[core-ai-bot]

Comment by larz0
Friday Mar 21, 2014 at 15:35 GMT

---

Yes this is great. Thanks@cheesypoof.

[core-ai-bot]

Comment by peterflynn
Friday Mar 21, 2014 at 17:12 GMT

---

Changing title (was: "Extension update notification") so this sounds less like a dupe of #6723

[core-ai-bot]

Comment by cheesypoof
Tuesday Mar 25, 2014 at 08:32 GMT

---

Glad this was resolved in #7287. I didn't quite understand though why the author of that patch felt the need to pick up this bug...

Thanks for the CLA clarification@JeffryBooher; I'll be sure to sign it before I send in a pull request in the future.

[core-ai-bot]

Comment by lkcampbell
Tuesday Mar 25, 2014 at 14:58 GMT

---

@cheesypoof, I think the author of the patch might have missed the reference to you wanting to fix this bug as a starter bug. They probably just saw the starter bug label and jumped on it.

Sometimes things move pretty fast here, we have a very active community :).

Don't worry though, we have lots and lots of work to be done here. Once you have signed the CLA you should be good to go. Welcome aboard!

[core-ai-bot]

Comment by logarytm
Tuesday Mar 25, 2014 at 20:32 GMT

---

Yes, I chose this bug for my first patch as I don't know Brackets code/APIs enough to fix more serious issues.