[CLOSED] New preference to be able to scroll past the end of the file

[core-ai-bot]

Issue by TomMalbran
Sunday Mar 09, 2014 at 21:52 GMT
Originally opened as adobe/brackets#7142

---

Since is sometimes hard to write at the bottom of the screen, this allows you to scroll past the end until the point that the last line becomes the first line in view. This can be enabled with a new preference which is disabled by default.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/7142/commits

[core-ai-bot]

Comment by redmunds
Monday Mar 10, 2014 at 15:17 GMT

---

I just noticed that the vertical scrollbar goes behind the little square in bottom-right corner. Removing the .CodeMirror-scrollbar-filler rule fixes that.

[core-ai-bot]

Comment by redmunds
Monday Mar 10, 2014 at 15:28 GMT

---

Done with review.

[core-ai-bot]

Comment by TomMalbran
Monday Mar 10, 2014 at 19:51 GMT

---

I just noticed that the vertical scrollbar goes behind the little square in bottom-right corner.

That has happened ever since we added custom scrollbars for the editor. Check this recent conversation adobe/brackets#5083 (comment)

Removing the .CodeMirror-scrollbar-filler rule fixes that.

Do you mean that it just goes to the bottom of the file or it actually stops where it should? If is the first one, we still have a bug, since both the horizontal and vertical thumbs would overlap at that corner.

[core-ai-bot]

Comment by redmunds
Monday Mar 10, 2014 at 20:02 GMT

---

Removing the .CodeMirror-scrollbar-filler rule fixes that.

Do you mean that it just goes to the bottom of the file or it actually stops where it should?

The vertical scroll thumb is already going to the bottom of the file even when there is a horizontal scroll bar, but the .CodeMirror-scrollbar-filler element is covering it up. I, personally, would prefer that it does not go all the way to the bottom in this case, but hiding part of the thumb is probably worse -- especially in files with a lot of lines and a small thumb.

The horizontal scroll thumb does not go into that corner, so there is no overlap.

But, this is for another pull request -- I just thought I'd mention it.

[core-ai-bot]

Comment by TomMalbran
Monday Mar 10, 2014 at 20:14 GMT

---

I actually can see the horizontal bar go beneath the vertical one. I would like if the scrollbars stop where they should. Notice that there is a min width in the thumb, so it will never be too small to not be able to grab it to scroll up. We should fill a new issue for that.

Pushed the fixes for this PR.

[core-ai-bot]

Comment by redmunds
Thursday Mar 13, 2014 at 16:22 GMT

---

@TomMalbran I'm ready to merge this into master, but there's 1 change you need to make.

[core-ai-bot]

Comment by TomMalbran
Thursday Mar 13, 2014 at 20:40 GMT

---

@redmunds Merged with master and fixed the require issue.

[core-ai-bot]

Comment by redmunds
Thursday Mar 13, 2014 at 21:56 GMT

---

Done with review. One more comment.

[core-ai-bot]

Comment by TomMalbran
Thursday Mar 13, 2014 at 23:18 GMT

---

@redmunds Changes pushed.

[core-ai-bot]

Comment by TomMalbran
Thursday Mar 13, 2014 at 23:40 GMT

---

@redmunds fixed

[core-ai-bot]

Comment by redmunds
Thursday Mar 13, 2014 at 23:42 GMT

---

Looks good. Merging.

[core-ai-bot]

Comment by TomMalbran
Thursday Mar 13, 2014 at 23:47 GMT

---

Woot :)

Added it to https://github.com/adobe/brackets/wiki/How-to-Use-Brackets#preferences