[CLOSED] Use styleSheetAdded and styleSheetRemoved, replaces getAllStylesheets

[core-ai-bot]

Issue by jasonsanjose
Wednesday Feb 26, 2014 at 00:18 GMT
Originally opened as adobe/brackets#7008

---

Fix for #6830

• Add styleSheetAdded and styleSheetRemoved event handling to inspector protocol
• Fallback to getAllStylesheets for Chrome < 34

Fix for #6912

• Use styleSheetAdded to keep styleSheetId values up to date to fix "No style sheet with given id found, code: -32000" when pushing change events from Brackets to Chrome

---

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/7008/commits

[core-ai-bot]

Comment by jasonsanjose
Wednesday Feb 26, 2014 at 01:07 GMT

---

Doh. I just realized that we should check for the original API in case the user is using an older version of Chrome.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Feb 26, 2014 at 02:18 GMT

---

Added fallback for getAllStyleSheets and duplicate detection if both the deleted API and the events are working. Tested on Mac 10.9 with Chrome 33.

Even though Chrome 33 should support both, I found that the styleSheetAdded and styleSheetRemoved events were not consistently fired by Chrome. The fallback was necessary in my testing otherwise live CSS editing would be broken.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Feb 26, 2014 at 02:19 GMT

---

Somewhat related to these changes is PR adobe/brackets#7010 to update the inspector protocol to the latest stable version.

[core-ai-bot]

Comment by redmunds
Thursday Feb 27, 2014 at 19:30 GMT

---

I'm seeing the this LiveDevelopment unit test fail every time on Win7 (both HD and SSD) and Chrome 33:

"should reload the page when editing a non-live document"

timeout: timed out after 1000 msec waiting for success [FILE_SAVE]

UPDATE: seeing same failure with Win7 (SSD) with Chrome 34.0.1847.11 beta-m.

[core-ai-bot]

Comment by redmunds
Thursday Feb 27, 2014 at 20:13 GMT

---

FYI, Win7 (HD) with Chrome 35 (canary) is a train wreck (7 of 9 fail). Getting "External Changes: simple1.css has been modified on disk, but also has unsaved changes in Brackets" warning dialog.

[core-ai-bot]

Comment by redmunds
Thursday Feb 27, 2014 at 21:24 GMT

---

There are a lot of conflicts with PR #6889 -- should these be merged?

[core-ai-bot]

Comment by jasonsanjose
Friday Feb 28, 2014 at 00:22 GMT

---

@redmunds Looking at the unit test failures now. Will send an update later today.

[core-ai-bot]

Comment by JeffryBooher
Friday Feb 28, 2014 at 01:12 GMT

---

@redmunds I assigned this PR to you since you are doing the review. Thanks for helping out with this.

[core-ai-bot]

Comment by jasonsanjose
Friday Feb 28, 2014 at 16:47 GMT

---

@redmunds fixed the failing unit tests except for an issue at teardown where removeTempDirectory fails. Feel free to review for now though.

[core-ai-bot]

Comment by jasonsanjose
Friday Feb 28, 2014 at 21:04 GMT

---

@redmunds let me know if you see a unit test failure at the end of the live dev suite due to removeTempDirectory. I can only reproduce on windows, not mac. I've scrubbed this code all morning looking for some material change that would maybe cause file watchers to hang on to a ref, which would maybe cause the error during cleanup, but I don't see anything.

[core-ai-bot]

Comment by redmunds
Friday Feb 28, 2014 at 21:10 GMT

---

@jasonsanjose Yes, I just saw it on Win7 (SSD) but not on Win7 (HD).

[core-ai-bot]

Comment by redmunds
Friday Feb 28, 2014 at 22:06 GMT

---

@jasonsanjose I tried to manually delete the test/temp folder and got the message: "The action can't be completed because the folder or file is open in another program". I shutdown Brackets and could then remove the folder. Now the tests pass. Interesting because I know that I had a clean git status when I started.

[core-ai-bot]

Comment by jasonsanjose
Tuesday Mar 04, 2014 at 17:42 GMT

---

@redmunds cleaned up those last few comments. Still no luck with the removeTempDirectory problem.

[core-ai-bot]

Comment by redmunds
Tuesday Mar 04, 2014 at 17:51 GMT

---

@jasonsanjose Do you have a repeatable recipe for the removeTempDirectory problem? If so, I can take a look.

[core-ai-bot]

Comment by jasonsanjose
Tuesday Mar 04, 2014 at 18:03 GMT

---

Unfortunately no. It happens about 90% of the time I run the live dev test suite.