[CLOSED] Live Preview fixes

[core-ai-bot]

Issue by redmunds
Monday Feb 17, 2014 at 02:48 GMT
Originally opened as adobe/brackets#6889

---

This is for #6122. Also is for #5687. And at least parts of #6830.

I also found a repeatable recipe that was causing connection errors when changing files, so I fixed the case of relaunching browser after "Relaunch Chrome" dialog is shown. See inline comments for more info.

---

redmunds included the following code: https://github.com/adobe/brackets/pull/6889/commits

[core-ai-bot]

Comment by redmunds
Monday Feb 17, 2014 at 02:59 GMT

---

@jasonsanjose Do you want to take a look? I think you were the last one to update this code.

[core-ai-bot]

Comment by redmunds
Wednesday Feb 19, 2014 at 18:10 GMT

---

@jasonsanjose Re-assigned to@ingorichter

[core-ai-bot]

Comment by redmunds
Friday Feb 21, 2014 at 16:03 GMT

---

@ingorichter@jasonsanjose Can someone make a first pass through this pull request? We should try to get this in for Release 37, and I have a few questions that still need to be resolved. Thanks.

[core-ai-bot]

Comment by jasonsanjose
Friday Feb 21, 2014 at 23:59 GMT

---

@redmunds initial review complete

[core-ai-bot]

Comment by redmunds
Saturday Feb 22, 2014 at 22:34 GMT

---

@jasonsanjose Pushed changes. Ready for next review.

[core-ai-bot]

Comment by ingorichter
Tuesday Feb 25, 2014 at 02:43 GMT

---

It seems better now, even if this is difficult to quantify. I haven't seen any error message that live preview couldn't get started. I only saw some issues with switching documents, but this behavior is the same on master.

[core-ai-bot]

Comment by jasonsanjose
Tuesday Feb 25, 2014 at 17:26 GMT

---

Working with@redmunds yesterday and still found some issues when switching the current document in Brackets when live preview is open:

1. Start live preview for html file A.html
2. Switch to B.html
3. While the browser is still shutting down/starting up, switch to C.html
4. Attempt to make live HTML edits
5. Observe edits are not pushed to browser

[core-ai-bot]

Comment by ingorichter
Tuesday Feb 25, 2014 at 17:48 GMT

---

I only saw this, IMHO weird behavior, when switching documents. Sometimes the live dev session was closed and in other cased the other document was load into the same session without closing the browser.

[core-ai-bot]

Comment by redmunds
Wednesday Feb 26, 2014 at 16:32 GMT

---

@jasonsanjose Ready for another review.

[core-ai-bot]

Comment by ingorichter
Wednesday Feb 26, 2014 at 22:12 GMT

---

Switching the documents will start a new session every time. This seems to be alright now.
F.Y.I. I don't think that this a real use-case, but starting and stopping Live Preview but constantly clicking the icon will result in an error after 4-6 times of doing so. I get an error and the console log shows Inspected frame has gone Object {code: -32000, message: "Inspected frame has gone"}

[core-ai-bot]

Comment by njx
Wednesday Feb 26, 2014 at 22:48 GMT

---

@ingorichter That last issue is worth filing - the fact that we get easily confused if you disconnect/reconnect rapidly. Some of the students were running into this at MissionBit.

[core-ai-bot]

Comment by jasonsanjose
Friday Mar 07, 2014 at 01:08 GMT

---

Unfortunately, I can still hit the "Unable to load Live Development page" error message following this comment adobe/brackets#6889 (comment).

Is it worth it to try changing reconnect to reuse the connection instead of a full teardown and restart?

[core-ai-bot]

Comment by jasonsanjose
Friday Mar 07, 2014 at 04:33 GMT

---

@redmunds I went ahead and changed how we load a new HTML page if live preview is already open. See #7119. I still need to scrub the tagged live preview issues to see which ones this fix addresses.

[core-ai-bot]

Comment by jasonsanjose
Friday Mar 07, 2014 at 22:20 GMT

---

Looks great. Merging.