[CLOSED] Fix several visual issues with find result highlighting:

[core-ai-bot]

Issue by peterflynn
Saturday Jan 11, 2014 at 02:00 GMT
Originally opened as adobe/brackets#6478

---

• Reduce width of scrollbar tickmarks to match new, narrower custom-themed scrollbars from [CLOSED] live preview - highlight on the browser would show up the corresponding css file in editor #6305 (should also look better on Mac, where the tickmarks were already too wide)
• Fix bug where showing/hiding a bottom panel didn't update the positioning of scrollbar tickmarks
• Results that span multiple tokens showed little orange dots in the text highlight between tokens (due to repeated corner rounding). There are still faint lines between tokens (due to box-shadow), but they're much fainter.

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/6478/commits

[core-ai-bot]

Comment by redmunds
Tuesday Jan 14, 2014 at 23:42 GMT

---

I'm not sure how to reproduce the 2nd and 3rd bullets in the description, so not sure about those.

[core-ai-bot]

Comment by peterflynn
Wednesday Jan 15, 2014 at 01:06 GMT

---

You can repro the 2nd bullet by getting some Find in Files results, then doing a regular find (causing tickmarks to appear), then closing the Find in Files panel. Or similar repro steps with the Markdown Preview bottom panel, etc.

[core-ai-bot]

Comment by peterflynn
Wednesday Jan 15, 2014 at 01:07 GMT

---

For the 3rd bullet just do a search that matches across more than one CM token. E.g. an identifier plus a punctuation/delimiter char. Example:

Before fix

With fix

Note the little red dots around the "." in the selected result (before the fix).

[core-ai-bot]

Comment by redmunds
Wednesday Jan 15, 2014 at 01:25 GMT

---

Here's a Mac screenshot:

[core-ai-bot]

Comment by redmunds
Wednesday Jan 15, 2014 at 01:46 GMT

---

@peterflynn Done with review. Unless you have any further changes you want to make, I am ready to merge this. Let me know.

[core-ai-bot]

Comment by peterflynn
Wednesday Jan 15, 2014 at 21:37 GMT

---

@redmunds If you're ok merging it as-is that works for me. I will look into scrollbar measuring for next sprint as a follow-up improvement.

[core-ai-bot]

Comment by redmunds
Wednesday Jan 15, 2014 at 21:41 GMT

---

Merging.