[CLOSED] For #6210: Graying out "Update" for "dev" extensions

[core-ai-bot]

Issue by MarcelGerber
Tuesday Dec 10, 2013 at 16:33 GMT
Originally opened as adobe/brackets#6222

---

Extensions that are in the dev folder can't be updated automatically any more (the "Update" button is grayed out).

This fixes #6210@peterflynn
German translation@couzteau

Please test this, I couldn't test this as I've got no own extension to test with.

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/6222/commits

[core-ai-bot]

Comment by dangoor
Monday Dec 16, 2013 at 19:41 GMT

---

Assigning myself to look at this.

[core-ai-bot]

Comment by MarcelGerber
Friday Jan 03, 2014 at 18:05 GMT

---

@dangoor Just changed. Is this a good approach?
And another question: Should the notifyCount (the green circle with the number of extensions with updates) mention updates that are not allowed?

[core-ai-bot]

Comment by dangoor
Friday Jan 03, 2014 at 18:52 GMT

---

@SAPlayer Yes, that looks great. One more thing: this code has a lot of tests. It would be good if you could add a test for this condition.

Excellent thought about the notifyCount, I hadn't thought of that. My opinion, and others could certainly disagree on this, is that including extensions that have updates available but where you can't update automatically because it's not installed in a user folder is actually a good thing because it tells people that they may want to update their dev copies.

What do you think?

[core-ai-bot]

Comment by peterflynn
Friday Jan 03, 2014 at 19:01 GMT

---

@dangoor I agree too

[core-ai-bot]

Comment by MarcelGerber
Friday Jan 03, 2014 at 20:41 GMT

---

I tried adding unit tests for so long, here's what I currently have:

it("should show disabled update button for items that are in dev folder and have a compatible update available", function () {
                    mockRegistry = { "mock-extension-2": makeMockExtension([">0.1", ">0.1"]) };
                    mockLoadExtensions(["dev/mock-extension-2"]);
                    setupViewWithMockData(ExtensionManagerViewModel.RegistryViewModel);


                    runs(function () {
                        var $button = $("button.update[data-extension-id=mock-extension-2]", view.$el);
                        expect($button.length).toBe(1);
                        expect($button.prop("disabled")).toBeTruthy();
                    });
                });

But it doesn't work. Can anyone maybe help?

[core-ai-bot]

Comment by dangoor
Saturday Jan 04, 2014 at 02:42 GMT

---

@SAPlayer I'll try to take a look on Monday. Thanks for working on getting a test in as well!

[core-ai-bot]

Comment by dangoor
Monday Jan 06, 2014 at 20:22 GMT

---

@SAPlayer Your test looks like it's on the right track, but I think I'll need to dig into it a bit later this week. I will try to get your change with a test landed this week though.

[core-ai-bot]

Comment by redmunds
Tuesday Jan 14, 2014 at 23:49 GMT

---

We don't use milestones on pull requests, I removed Sprint 36 milestone.

[core-ai-bot]

Comment by dangoor
Wednesday Jan 15, 2014 at 02:54 GMT

---

@SAPlayer Your test was on the right track... I made some changes to how the mocks were created and got it working. I also added the word "folder" to the English string. This is now merged into master. Thanks for the change!