Skip to content

[CLOSED] Implement steps() timing function editor #5312

@core-ai-bot

Description

@core-ai-bot

Issue by redmunds
Thursday Oct 31, 2013 at 23:37 GMT
Originally opened as adobe/brackets#5799


  1. I added support for steps() timing function.
  2. I refactored the existing inline timing function code for cubic-bezier().
  3. I developed this using TDD, so this includes Unit Tests.

Support for:

  • steps(<integer>[,[start|end]]) function
  • step-start
  • step-end

Keyboard Events

  • up/down arrows control steps
  • left/right arrows control start/end

Mouse support

  • None. Doesn't seem like any natural gestures.

Issues?

  • Edit controls?
    • count spin control
    • toggle switch for start/end
  • More then ~25 steps is not usable
    • dynamically make lines thinner as number of steps grows?
    • increase size of editor?
    • rescale grid?
  • Editing doc while editor open is unforgiving
    • e.g. While typing "start", editor closes due to intermediate updates
  • Validation
  • editor silently fails when invalid parameters
  • Proposed Showing Errors for Inline Editors to help solve this issue. Note this also helps cubic-bezier() and all other Inline Editors.

redmunds included the following code: https://github.com/adobe/brackets/pull/5799/commits

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions