[CLOSED] Expand / Collapse All for "Find In Files" result.

[core-ai-bot]

Issue by sathyamoorthi
Wednesday Oct 30, 2013 at 05:46 GMT
Originally opened as adobe/brackets#5757

---

Based on this Google groups discussion

CC: @larz0,@njx,@TomMalbran

---

sathyamoorthi included the following code: https://github.com/adobe/brackets/pull/5757/commits

[core-ai-bot]

Comment by MarcelGerber
Wednesday Oct 30, 2013 at 14:38 GMT

---

Maybe we could make this more visible, when we do it like this users have to remember one more trick.

[core-ai-bot]

Comment by larz0
Wednesday Oct 30, 2013 at 21:33 GMT

---

@SAPlayer we could use a tooltip "Ctrl/Cmd Click to Expand/Collapse all."

@sathyamoorthi Ctrl click doesn't work for me. Could it be because I'm on Mac OS X?

[core-ai-bot]

Comment by sathyamoorthi
Thursday Oct 31, 2013 at 06:35 GMT

---

@larz0 yes. That was mac only issue. Could you please try now?

[core-ai-bot]

Comment by larz0
Thursday Oct 31, 2013 at 19:24 GMT

---

@sathyamoorthi nice it works now :) Could you add title attribute to the triangle span so we can get a tooltip? This is awesome.

[core-ai-bot]

Comment by sathyamoorthi
Friday Nov 01, 2013 at 00:41 GMT

---

@larz0 small change. added that.

[core-ai-bot]

Comment by sathyamoorthi
Friday Nov 22, 2013 at 09:09 GMT

---

@JeffryBooher any chance to pull this in? only simple changes.

[core-ai-bot]

Comment by larz0
Sunday Jan 19, 2014 at 00:00 GMT

---

@JeffryBooher PRETTY PLEASE WITH 🍉 ON TOP~

[core-ai-bot]

Comment by TomMalbran
Sunday Jan 19, 2014 at 00:21 GMT

---

I totally forgot about this PR. I guess I just did a full code review. Haven't tested it yet since is quite behind master. Could you merge it with master too?

I guess I could revive this PR if@sathyamoorthi is not available.

[core-ai-bot]

Comment by larz0
Sunday Jan 19, 2014 at 00:46 GMT

---

Thanks@TomMalbran!

[core-ai-bot]

Comment by sathyamoorthi
Monday Jan 20, 2014 at 03:25 GMT

---

@TomMalbran if you wish, please take this forward. I can't get into this for next 2 to 3 days.

[core-ai-bot]

Comment by TomMalbran
Monday Jan 20, 2014 at 03:29 GMT

---

You can do it (I was going to do it if I got no response in like a week or 2). We still need to wait for Sprint 36 to end, and we will have like 3 more weeks until Sprint 37 when this could be released, so we have plenty of time.

[core-ai-bot]

Comment by sathyamoorthi
Monday Jan 20, 2014 at 03:44 GMT

---

@TomMalbran Cool. Let me fix this and get back to you in few days. Thanks.

[core-ai-bot]

Comment by TomMalbran
Wednesday Jan 22, 2014 at 19:28 GMT

---

@JeffryBooher If you are busy with other stuff I can take this PR.

[core-ai-bot]

Comment by sathyamoorthi
Thursday Jan 23, 2014 at 08:55 GMT

---

@TomMalbran Please do another review.

[core-ai-bot]

Comment by TomMalbran
Thursday Jan 23, 2014 at 19:46 GMT

---

@sathyamoorthi Second pass done. I like how you used the same code to do both collapse actions. I just added 2 nit comments.

It looks like the commits got messed up? There are a few repeated and one from dangoor.