[CLOSED] console.assert() missing from code hints

[core-ai-bot]

Issue by peterflynn
Sunday Apr 28, 2013 at 23:54 GMT
Originally opened as adobe/brackets#3655

---

1. Type console.a

Result: "assert" is not listed in code hints

Expected: You get hints for console.log(), console.warn(), and console.error(), so assert() should be included too.

[core-ai-bot]

Comment by pfarland
Monday Apr 29, 2013 at 19:28 GMT

---

The built-ins are from Tern.JS defs files, with console specifically defined in browser.json.
https://github.com/marijnh/tern/blob/master/defs/browser.json

These appear to be based on the Gecko (Mozilla) documentation, which does not list a console.assert() method.

[core-ai-bot]

Comment by peterflynn
Tuesday Apr 30, 2013 at 20:49 GMT

---

Since console.assert() is defined in Chrome, Safari, and Firebug I wonder if it wouldn't be such a hard sell to get it added. Is there a general policy on how many browsers need to support something before it's added to Tern's default built-ins?

[core-ai-bot]

Comment by njx
Friday May 03, 2013 at 20:26 GMT

---

Reviewed. To@peterflynn, low priority, adding "tracking" (not creating a "tern" label yet since it's not clear whether we'll have a lot of these). Peter--I wonder if we should consider just making a pull request directly to Marijn with the addition to the browser.json file?

[core-ai-bot]

Comment by pfarland
Friday May 03, 2013 at 20:38 GMT

---

We can always try, doesn't seem unreasonable. I'll ask@dloverin to take a look.

[core-ai-bot]

Comment by eztierney
Thursday May 16, 2013 at 14:23 GMT

---

What about the other console methods that are non-standard, but match between safari, chrome, and firebug? Methods like

console.dir
console.profile
console.group
etc

Do we want hints for all the common methods?

chrome: https://developers.google.com/chrome-developer-tools/docs/console-api#consoleassertexpression_object
firebug: http://getfirebug.com/wiki/index.php/Console_API
safari: https://developer.apple.com/library/safari/#documentation/AppleApplications/Conceptual/Safari_Developer_Guide/DebuggingYourWebsite/DebuggingYourWebsite.html (need to search for Console API, it's near the end)
ie: http://msdn.microsoft.com/en-us/library/ie/hh772183(v=vs.85).aspx

It looks like even ie10 adds 'assert'.

Also, even if these aren't in tern, we can write .json files for whatever we want and load them into tern. It looks like they are additive, so we can just add the missing methods in, and we wouldn't have to duplicate the entire browser.json file.

[core-ai-bot]

Comment by redmunds
Monday Mar 17, 2014 at 21:19 GMT

---

Was assigned to tern team, so marking "Needs Review".

[core-ai-bot]

Comment by ficristo
Sunday Feb 19, 2017 at 15:35 GMT

---

I see console.assert and console.group in the hints, but not console.profile.
I'd say this is fixed.