[CLOSED] Use language id instead of CodeMirror mode in CodeHintManager

[core-ai-bot]

Issue by WebsiteDeveloper
Wednesday Mar 27, 2013 at 23:10 GMT
Originally opened as adobe/brackets#3270

---

A possible fix for: #3085.

---

WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/3270/commits

[core-ai-bot]

Comment by peterflynn
Thursday Mar 28, 2013 at 17:29 GMT

---

@iwehrman might want to take a quick look at the changes to the JS hinting code, too.

[core-ai-bot]

Comment by iwehrman
Thursday Mar 28, 2013 at 18:09 GMT

---

Looks OK to me, assuming "javascript" actually is the language ID for JavaScript.

When testing this, it would be good idea to double-check that JavaScript hinting remains disabled on HTML pages inside of script tags.

[core-ai-bot]

Comment by WebsiteDeveloper
Thursday Mar 28, 2013 at 18:22 GMT

---

@iwehrman i double-checked it and it remains disabled.
And yes "javascript" is the language id (defined in languages.json).

[core-ai-bot]

Comment by DennisKehrig
Thursday Mar 28, 2013 at 22:58 GMT

---

Good timing! I just sorted this in under "Straightforward refactoring" on the language support Wiki page.

[core-ai-bot]

Comment by TomMalbran
Thursday Mar 28, 2013 at 23:00 GMT

---

@DennisKehrig You can remove the JSLintUtils from that list now :)

[core-ai-bot]

Comment by DennisKehrig
Thursday Mar 28, 2013 at 23:04 GMT

---

@WebsiteDeveloper Awesome work, looking forward to merging this!
Please search CodeHintManager.js for the string "mode", there are still a few references (comments only, though).

[core-ai-bot]

Comment by DennisKehrig
Thursday Mar 28, 2013 at 23:17 GMT

---

@TomMalbran Good point! I marked it as done, even though you did all the work. :)

[core-ai-bot]

Comment by TomMalbran
Thursday Mar 28, 2013 at 23:30 GMT

---

@DennisKehrig That is ok, just wanted to mention it. There is still a second bullet point about JSLint, that I think I covered in the refactor.

[core-ai-bot]

Comment by DennisKehrig
Thursday Mar 28, 2013 at 23:36 GMT

---

@TomMalbran Thanks again :) I need sleep...

[core-ai-bot]

Comment by WebsiteDeveloper
Friday Mar 29, 2013 at 12:53 GMT

---

@DennisKehrig all Done.

[core-ai-bot]

Comment by DennisKehrig
Saturday Mar 30, 2013 at 12:12 GMT

---

Awesome, I'll check again on Monday! Thank you for your patience :)

[core-ai-bot]

Comment by DennisKehrig
Monday Apr 01, 2013 at 21:35 GMT

---

Merged! Seems to have worked well :)

[core-ai-bot]

Comment by peterflynn
Tuesday Apr 02, 2013 at 22:40 GMT

---

@WebsiteDeveloper@DennisKehrig this is a breaking API change for other CodeHintManager clients (e.g. the TypeScript extension). I've added this to the release notes, but can one of you place post a heads-up message in the forum also?

[core-ai-bot]

Comment by WebsiteDeveloper
Wednesday Apr 03, 2013 at 12:41 GMT

---

@peterflynn i put up a notification in the google group

[core-ai-bot]

Comment by peterflynn
Wednesday Apr 03, 2013 at 23:15 GMT

---

Thanks!