[CLOSED] JSLint icon in status bar: incorrect counts

[core-ai-bot]

Issue by walesmd
Saturday Jan 26, 2013 at 20:59 GMT
Originally opened as adobe/brackets#2688

---

Originally noticed in ./src/htmlContent/main-view.html, confirmed by editing a .js file to manually create errors: when tooltip on the JSLint indicator within the status bar is off by +1.

1. Open ./src/htmlContent/main-view.html
2. Count 2 errors in JSLint status window
3. Hover over the JSLint indicator in status bar, see "3 JSLint Errors"
4. Open ./src/brackets.js
5. Edit line 30 to read: "text" "thirdparty/text", and save.
6. Count 3 errors & 1 stop notice in JSLint status window
7. Hover over JSLint indicator in status bar, see "5 JSLint Errors"

[core-ai-bot]

Comment by kjgorman
Sunday Jan 27, 2013 at 07:57 GMT

---

Hm, this seems to be due to L6597 of jslint that pushes a null value onto the list of JSLINT.errors. The status bar should probably count non-null jslint errors, I'll submit a pull request for this.

[core-ai-bot]

Comment by pthiess
Monday Jan 28, 2013 at 23:18 GMT

---

Reviewed, low priority

[core-ai-bot]

Comment by kjgorman
Monday Jan 28, 2013 at 23:23 GMT

---

Should probably be in the issue:

@peterflynn brings up a good point in my pull request that maybe this shouldn't be considered 'off by one' but indicative of an indeterminate upper bound (which I guess is more in line with a jslint stop notice):

Feel free to ignore this, but I think an even cooler option would be to change the status bar to say "3+ errors" or "> 3 errors" or something like that -- since the null seems to indicate JSLint giving up prematurely without scanning the entire file.

[core-ai-bot]

Comment by redmunds
Tuesday Jan 29, 2013 at 17:07 GMT

---

Great detective work@peterflynn!

@kjgorman That seems like a simple change to provide even better information. Do you want to update your branch for this?

[core-ai-bot]

Comment by walesmd
Tuesday Jan 29, 2013 at 19:52 GMT

---

What an improvement a few characters make! My thoughts immediately go from "hah, that's wrong!" to "OMG, this code is horrible; JSLint isn't even going to waste the time to count the ways... Definitely not committing this until there's some refactoring." 😃

[core-ai-bot]

Comment by redmunds
Tuesday Jan 29, 2013 at 21:32 GMT

---

Confirmed.