Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Factor out generic token-navigation routines from HTMLUtils #1708

Open
core-ai-bot opened this issue Aug 29, 2021 · 2 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by njx
Wednesday Oct 03, 2012 at 15:23 GMT
Originally opened as adobe/brackets#1753


HTMLUtils had a number of private functions that navigate through the CodeMirror code coloring tokens in the current editor. These are completely generic (not specific to HTML), and would be useful for extensions that need to do light parsing based on the tokenization. This pull request factors those functions out into a separate TokenUtils class.


njx included the following code: https://github.com/adobe/brackets/pull/1753/commits

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Oct 03, 2012 at 15:23 GMT


@peterflynn

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Oct 03, 2012 at 15:57 GMT


Cool. Eventually I think we should have a TokenIterator sort of class that packages this up even more cleanly (and probably hides _codeMirror a bit better too), and this seems like a solid step in that direction.

Diff looks good to me -- merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant