This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Factor out generic token-navigation routines from HTMLUtils #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Cool. Eventually I think we should have a TokenIterator sort of class that packages this up even more cleanly (and probably hides _codeMirror a bit better too), and this seems like a solid step in that direction. Diff looks good to me -- merging. |
peterflynn
added a commit
that referenced
this pull request
Oct 3, 2012
Factor out generic token-navigation routines from HTMLUtils
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTMLUtils had a number of private functions that navigate through the CodeMirror code coloring tokens in the current editor. These are completely generic (not specific to HTML), and would be useful for extensions that need to do light parsing based on the tokenization. This pull request factors those functions out into a separate TokenUtils class.