[CLOSED] Move initialization of Brackets object from appshell_extensions.js to Global.js

[core-ai-bot]

Issue by nethip
Tuesday Dec 12, 2017 at 13:50 GMT
Originally opened as adobe/brackets#13975

---

With newer versions of CEF, brackets object initialization inside appshell_extensions.js is causing a crash in the app. So moved the initialization to Brackets side where Brackets variable is defined. This was required as we are moving to a later version of CEF, 2785 on Linux only.

@abhijitapte@boopeshmahendran Could you please review this PR?

---

nethip included the following code: https://github.com/adobe/brackets/pull/13975/commits

[core-ai-bot]

Comment by nethip
Tuesday Dec 12, 2017 at 13:59 GMT

---

brackets-shell relevant PR: adobe/brackets-shell#626

Note: Both the PRs need to be merged.

[core-ai-bot]

Comment by boopeshmahendran
Tuesday Dec 12, 2017 at 17:14 GMT

---

@nethip The travis build is failing due to ReferenceError: Can't find variable: appshell. Is it expected?

[core-ai-bot]

Comment by nethip
Wednesday Dec 13, 2017 at 09:17 GMT

---

@boopeshmahendran Not really. I will fix it the lint error.

[core-ai-bot]

Comment by nethip
Thursday Dec 14, 2017 at 12:15 GMT

---

@petetnt I have added the file reference. Can you check if the PR is fine?

[core-ai-bot]

Comment by navch
Wednesday Dec 20, 2017 at 05:59 GMT

---

LGTM 👍