[CLOSED] Upgrade less from 2.5.1 to 2.7.2

[core-ai-bot]

Issue by ficristo
Monday Jan 02, 2017 at 08:17 GMT
Originally opened as adobe/brackets#13019

---

I would like to upgrade grunt related dependencies and this was in the way: updating only the grunt dep without the thirdparty didn't seem good.
I renamed less-2.5.1.min.js to simply less.min.js, you can see the version in the comments inside the file.

---

ficristo included the following code: https://github.com/adobe/brackets/pull/13019/commits

[core-ai-bot]

Comment by zaggino
Monday Jan 02, 2017 at 09:13 GMT

---

could we maybe switch to npm dependency instead?

[core-ai-bot]

Comment by ficristo
Monday Jan 02, 2017 at 12:25 GMT

---

I'm all for moving to npm.
But has pointed out before by@busykai, we need to do something about the increase size of the bundle.
For example less 2.7.1 from npm is about 3MB, but the minified file is only 140kB.
I have some random thought but still nothing good.
So WDYT?

[core-ai-bot]

Comment by zaggino
Monday Jan 02, 2017 at 20:50 GMT

---

Is it about npm not providing minified file or about npm providing too many files that we don't need?

[core-ai-bot]

Comment by ficristo
Tuesday Jan 03, 2017 at 08:25 GMT

---

Too many files, I've opened #13020 as a possible solution

[core-ai-bot]

Comment by ficristo
Sunday Jan 08, 2017 at 08:23 GMT

---

Now it is fetched from npm.

[core-ai-bot]

Comment by zaggino
Monday Jan 09, 2017 at 13:16 GMT

---

👍 cool

[core-ai-bot]

Comment by ficristo
Monday Jan 09, 2017 at 18:55 GMT

---

Thank you.