[CLOSED] Remove unneeded CSS prefixes and length unit symbols

[core-ai-bot]

Issue by valtlai
Thursday Jan 28, 2016 at 09:41 GMT
Originally opened as adobe/brackets#12163

---

• Remove -webkit- prefixes from transition and flexbox-related properties
• Remove -webkit- prefix inside unprefixed @keyframes
• Add missing unprefixed transforms
• Remove px unit from 0px values

(+ Remove whitespace from end of lines)

---

valtlai included the following code: https://github.com/adobe/brackets/pull/12163/commits

[core-ai-bot]

Comment by petetnt
Thursday Jan 28, 2016 at 09:44 GMT

---

LGTM

[core-ai-bot]

Comment by redmunds
Thursday Jan 28, 2016 at 15:33 GMT

---

@valtlait

The original email notification I received said this:

(+ Remove whitespace from end of lines and empty lines)

But message in PR now says this:

(+ Remove whitespace from end of lines)

It looks like it was edited to remove "and empty lines". But, I still see lines with only whitespace that were edited to remove whitespace in this PR. Please backout those changes and rebase into a single commit. Thanks.

In general:

Yes, please remove whitespace from the end of non-empty lines.

Please do not remove whitespace from empty lines. This is not part of the Brackets coding conventions. It's optional based on developer tastes. It doesn't do any good to remove it because the next dev might put it back. Worst of all, the change will show up as a merge conflict for the next poor soul that edits a line near that change, so it causes unnecessary pain.

Exception: whitespace on empty lines should be at correct indentation level, so it's ok to correct that. But no need to scan files for this -- just correct it in code blocks that you are editing for some other reason.

[core-ai-bot]

Comment by petetnt
Thursday Jan 28, 2016 at 15:55 GMT

---

FWIW There was discussion about this on #11998 too and@peterflynn suggested (for the code) "no-trailing-spaces": [2, { "skipBlankLines": true }] which I think makes some sense. The thing is that when no-trailing-spaces is enabled you can't really use an automatic whitespace sanitizer, without doing tons of silly diffs all over the documents. But then again CodeMirror likes to put whitespace allover the place so there's you have either to endure the manual removal of trailing spaces, let them be or just remove them all, all of which have their downsides.

[core-ai-bot]

Comment by valtlai
Thursday Jan 28, 2016 at 17:40 GMT

---

Reverted whitespace changes for empty lines.

[core-ai-bot]

Comment by redmunds
Thursday Jan 28, 2016 at 19:14 GMT

---

@valtlait Thank you!

[core-ai-bot]

Comment by valtlai
Saturday Jan 30, 2016 at 14:49 GMT

---

• Restored -webkit- prefix to transform
• Removed -webkit- prefix inside unprefixed @keyframes
• Added missing unprefixed transforms

[core-ai-bot]

Comment by ficristo
Wednesday Aug 03, 2016 at 20:38 GMT

---

@valtlai could you update the PR?
It LGTM but I prefer if someone else could do the last check.

[core-ai-bot]

Comment by valtlai
Wednesday Aug 03, 2016 at 21:33 GMT

---

@ficristo Updated.

[core-ai-bot]

Comment by ficristo
Wednesday Aug 03, 2016 at 21:51 GMT

---

@valtlai the merge didn't end well, can you check?

[core-ai-bot]

Comment by valtlai
Thursday Aug 04, 2016 at 01:04 GMT

---

Replaced with #12648.