[CLOSED] Replaced util macros in favour of cef_helpers|cef_logging ones

[core-ai-bot]

Issue by ficristo
Monday May 30, 2016 at 19:16 GMT
Originally opened as adobe#557

---

And I removed the file since now it is unused.

---

ficristo included the following code: https://github.com/adobe/brackets-shell/pull/557/commits

[core-ai-bot]

Comment by ficristo
Wednesday Jun 15, 2016 at 15:02 GMT

---

/cc @ingorichter if you have a bit of time...

[core-ai-bot]

Comment by nethip
Tuesday Jun 21, 2016 at 15:31 GMT

---

Great job @ficristo 👍 Really appreciate it!

[core-ai-bot]

Comment by nethip
Tuesday Jun 21, 2016 at 15:36 GMT

---

I tried building remove-util branch on MAC and I am getting this error.

@ficristo Could you have a look at this error?

[core-ai-bot]

Comment by ficristo
Tuesday Jun 21, 2016 at 18:41 GMT

---

The defines to check the OS weren't working (not on OSX).
I tryed adding the cef_build or cef_task or cef_logging headers but it causes some problems on Windows.
I've copied the code to define the OS from the cef_build header, now it should work.

[core-ai-bot]

Comment by nethip
Tuesday Jun 21, 2016 at 19:07 GMT

---

I am able to build this now on MAC.

[core-ai-bot]

Comment by nethip
Tuesday Jun 21, 2016 at 19:08 GMT

---

Thanks @ficristo