[CLOSED] Linux native menus

[core-ai-bot]

Issue by eyelash
Sunday May 18, 2014 at 08:53 GMT
Originally opened as adobe#444

---

I improved the Linux native menus a bit. There is still a lot to do (and I will keep working on it) but the improvements are already worth merging.

---

eyelash included the following code: https://github.com/adobe/brackets-shell/pull/444/commits

[core-ai-bot]

Comment by ingorichter
Wednesday May 21, 2014 at 15:44 GMT

---

@eyelash Thanks for getting this implemented. A couple of months ago (sigh), I proposed to keep a feature branch to implement this feature. This way we can implement and test everything in isolation before merging to master without having to fear any issues in master.

[core-ai-bot]

Comment by eyelash
Wednesday May 21, 2014 at 15:50 GMT

---

You could still create such a feature branch and then merge my branch into the feature branch instead of master.
Originally I wanted to work on your branch but then pull request #348 was merged into master so I thought it was OK to work on the master branch.

[core-ai-bot]

Comment by ingorichter
Wednesday May 21, 2014 at 20:21 GMT

---

That what I'm going to do.

[core-ai-bot]

Comment by ingorichter
Tuesday May 27, 2014 at 20:12 GMT

---

@eyelash I have created the feature branch in https://github.com/adobe/brackets-shell/tree/ingo/linux-native-menus and merged your changes into this branch already. I'm going to close this PR in favor of the new branch. Thanks!