[CLOSED] implement MoveFileOrDirectoryToTrash on Linux

[core-ai-bot]

Issue by eyelash
Sunday Aug 18, 2013 at 17:20 GMT
Originally opened as adobe#304

---

I tested (on Ubuntu 13.10):

• deleting files
• deleting directories

both worked

---

eyelash included the following code: https://github.com/adobe/brackets-shell/pull/304/commits

[core-ai-bot]

Comment by timburgess
Tuesday Aug 20, 2013 at 06:19 GMT

---

I like the idea of using g_file_trash(). I've submitted some code for the same function in another PR but it's much more lower level C code and will only work with the Ubuntu trash. Using g_file_trash() there is more likely a chance that it will work with trash on other distros. If someone could test on a non-Ubuntu flavor that would be great.

[core-ai-bot]

Comment by jasonsanjose
Thursday Aug 22, 2013 at 16:23 GMT

---

Linking to #284. Reviewing both.

[core-ai-bot]

Comment by jasonsanjose
Friday Aug 23, 2013 at 05:29 GMT

---

Looks good and tested on Ubuntu 13 64-bit after merging with master locally.

If I understand my libraries right...GIO is part of GLib. Since we require this in our debian package control file as a dependency, and presumably will require it for other distributions (Fedora is probably next), this should work across distributions right?

@eyelash it doesn't matter much currently since we don't have support for other distros yet. If you happen to know if this works on Fedora, just leave a note here.

Merging.

[core-ai-bot]

Comment by eyelash
Friday Aug 23, 2013 at 15:12 GMT

---

GTK+ depends on GLib so every distribution that has GTK+ also has GLib. I don't use fedora but I'm quite sure this solution works for most of the distributions.

[core-ai-bot]

Comment by jasonsanjose
Friday Aug 23, 2013 at 16:58 GMT

---

Great. Thanks @eyelash. Also, thanks for signing the CLA.