Exit gracefully if conf.intf.ifname does not exist #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudipm-mukherjee
force-pushed
the
sudip/ubuntu
branch
from
dcc4a4e to
27d3597
Compare
br101
requested changes
Jan 5, 2024
Owner
br101
left a comment
br101
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
check_if_exists() should be a function in libuwifi/netdev.c and be called something like
netdev_check_if_exists() or similiar.
Otherwise fine. Thank you
horst will only work if there is a wlan interface. But if any user tries horst on a system where there is no wifi hardware then it results in a segfault. As an added benifit this will also protect the user against any misconfiguration of the wlan interface name. The segfault has been reported in Ubuntu. Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
sudipm-mukherjee
force-pushed
the
sudip/ubuntu
branch
from
27d3597 to
88dcc70
Compare
Author
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
horst will only work if there is a wlan interface. But if any user tries horst on a system where there is no wifi hardware then it results in a segfault.
As an added benifit this will also protect the user against any misconfiguration of the wlan interface name.
Depends on: br101/libuwifi#9