Housekeeping + prepare v1.1.0
#35
Conversation
There was a problem hiding this comment.
Pull request overview
Prepares the repository for the v1.1.0 release by updating core runtime dependencies and modernizing the development/tooling stack (including CI).
Changes:
- Bump runtime deps to
min-dash@5andmin-dom@5. - Update a broad set of dev/build/test dependencies (bpmn-js ecosystem, bundling, testing, puppeteer, etc.).
- Update CI workflow to newer action versions and run on a newer Node.js version.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updates runtime + dev dependency versions (notably min-dash, min-dom, and test/build tooling). |
| CHANGELOG.md | Adds a 1.1.0 section describing dependency updates. |
| .github/workflows/CI.yml | Updates GitHub Actions workflow matrix and action versions for CI runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## 1.1.0 | ||
|
|
||
| * `DEPS`: update to `min-dash@5.0.0` | ||
| * `DEPS`: update to `min-dom@5.2.0` |
There was a problem hiding this comment.
The changelog introduces a 1.1.0 section, but package.json still declares version 1.0.0. If this PR is meant to “prepare v1.1.0”, the package version should be bumped to match before tagging/releasing.
| "html-webpack-plugin": "^5.6.6", | ||
| "karma": "^6.4.4", | ||
| "karma-chrome-launcher-2": "^3.3.0", | ||
| "karma-coverage": "^2.2.1", | ||
| "karma-debug-launcher": "^0.0.5", |
There was a problem hiding this comment.
Switching to karma-chrome-launcher-2 pulls in which@6 (via the lockfile) which requires Node ^20.17.0 || >=22.9.0. Since package.json has no engines field, installs on older Node 20.x (or 18.x) may now fail unexpectedly; consider documenting/enforcing the minimum supported Node version (e.g. via engines) or sticking with a launcher dependency that supports your intended Node range.
| ## 1.1.0 | ||
|
|
||
| * `DEPS`: update to `min-dash@5.0.0` | ||
| * `DEPS`: update to `min-dom@5.2.0` |
There was a problem hiding this comment.
This 1.1.0 changelog entry only mentions the runtime dependency bumps (min-dash, min-dom), but the PR also updates a number of other dependencies (dev/build/test). If those are intentionally omitted, consider adding a short note (e.g. “devDependencies updated”) to avoid the changelog appearing incomplete for the release.
| * `DEPS`: update to `min-dom@5.2.0` | |
| * `DEPS`: update to `min-dom@5.2.0` | |
| * `CHORE`: update devDependencies |
|
Not sure how this got merged, still red 🙄 |
|
My bad 🤣 
|
1 participant
Proposed Changes
Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool