Skip to content

Add output collection group for ad-hoc subprocess #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2025

Conversation

barmac
Copy link
Member

@barmac barmac commented Aug 4, 2025

Proposed Changes

This PR adds support for new ad-hoc subprocess via output collection group.

image

Related to https://github.com/camunda/tmp-camunda-modeler-adhoc-subprocess/issues/3

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 4, 2025
@barmac barmac requested review from a team, philippfromme and abdul99ahad and removed request for a team August 4, 2025 12:09
@barmac barmac marked this pull request as draft August 4, 2025 12:29
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Aug 4, 2025
@barmac barmac force-pushed the ad-hoc-completion-support branch from bb3b9ec to 1d0f0c3 Compare August 4, 2025 13:52
@barmac barmac marked this pull request as ready for review August 4, 2025 13:52
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 4, 2025
});


describe('undo/redo', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a duplicate of the should update output element on external change tests? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove it then.

@philippfromme philippfromme merged commit 6c3aa2a into main Aug 14, 2025
9 checks passed
@philippfromme philippfromme deleted the ad-hoc-completion-support branch August 14, 2025 14:27
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants