Fix isolate leak on teardown #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were sometimes leaking isolates on shutdown because of reference cycles. In particular, the
IsolateManager
could be running a perpetual (or self-restarting) task which containsshared_ptr
references to objects which in turn containshared_ptr
references to theIsolateManager
.This change simplifies the lifecycle of most things in the C++ side of
PyMiniRacer
. Instead of usingshared_ptr
to manage lifecycle, we more explicitly manage lifecycles. Any objects which send tasks to theIsolateManager
are, obviously, responsible for ensuring those tasks complete before any objects those tasks reference (usually including the task-creatingthis
object) are destructed.IsolateManager::Run
now returns afuture
to make that easier to do.Closes #62.