Support for configurable debug port (issue 1429) #2
+276
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparadie
pushed a commit
that referenced
this pull request
Aug 29, 2015
Summary: The context wasn't being explicitly released before, since it'd be immediately released. Now that the executors are bridge modules, it was only being deallocated when the modules were released, what caused the threads to not be released at all.
bparadie
pushed a commit
that referenced
this pull request
Aug 29, 2015
Summary: Fixes facebook#1642 When reloading during profiling, the profile wouldn't unhook from the instance being deallocated.
bparadie
force-pushed
the
webSocketConfig
branch
from
4caebf4
to
bd925ac
Compare
Reviewed By: @DmitrySoshnikov Differential Revision: D2445071
Summary: I can't find anywhere these are being used by the bridge / native views anymore. I don't think they work anymore. ART has a similar API but uses a different code path. We might as well clean this up. Makes it easier to reason about. @public Reviewed By: @vjeux Differential Revision: D2445353
Summary: @public RCTNetworking currently relies on network responses to include an accurate text encoding, otherwise it is unable to convert the response data to text unless it's encoded as UTF8. See: facebook#1780 (comment) for details. This diff makes use of a new feature in iOS8 to detect the encoding of the text authomatically Reviewed By: @sahrens Differential Revision: D2443446
Jest 0.5.2 ships with a fix for bound functions, which RN exercises. And with this Travis change, the automated tests will install Node 4.x with nvm before running. Test Plan:`nvm use 4 && npm i && npm test` See if Travis tests pass.
Summary: beeper node modules has a `return` statement outside of a function which doesn't parse. To fix it, we mock it. Also, setupEnvPolyfills is no longer being used. Closes facebook#2770 Reviewed By: @svcscm Differential Revision: D2448882 Pulled By: @vjeux
…o webSocketConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in facebook#1429.