Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): dontBreakRows not fitting on single page #1159 #2186

Closed
wants to merge 2 commits into from

Conversation

akyrey
Copy link

@akyrey akyrey commented Feb 2, 2021

Should fix issue #1159 related to dontBreakRows that would completely remove the row if it would not fit on a single page

@liborm85
Copy link
Collaborator

Tested with example from #1159, but is same behavior. What was it supposed to fix?

@masterk63
Copy link

Hi, @akyrey I was testing, and yes fix my problem, works like a charm, could you please merged it, I gonna love it.

@akyrey
Copy link
Author

akyrey commented Apr 9, 2021

@liborm85 sorry to reply a bit late. You are right, I tested my changes on the example from #1159 and it didn't work. I tried playing around a bit with that example and I found out that it works correctly if table layout is set to noBorders. That's probably why it works correctly on my environment and for @masterk63

I'm gonna close current merge request since it is related to master branches and open a new one for branch 0.1

@akyrey
Copy link
Author

akyrey commented Apr 9, 2021

Reopened as #2231

@akyrey akyrey closed this Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants