Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pagelimit default #933

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Remove pagelimit default #933

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2fff55d
Remove pageLimit default and make itemsPerPage required
niwsa Feb 23, 2024
6835846
Fix typings
niwsa Feb 23, 2024
b4b123c
isPaginated should be `if paginate or itemsPerPage is not defined`
niwsa Feb 23, 2024
3bbcd3d
Merge branch 'main' into remove-pagelimit-default
niwsa Mar 4, 2024
ad64379
Merge branch 'main' into remove-pagelimit-default
niwsa Mar 4, 2024
8f81306
Merge branch 'main' into remove-pagelimit-default
niwsa Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
isPaginated should be if paginate or itemsPerPage is not defined
  • Loading branch information
@niwsa
niwsa committed Feb 23, 2024
commit b4b123c46d36ab9baad6c0b72e5b13c9caf21f3d
2 changes: 1 addition & 1 deletion src/dsync/DirectoryList/index.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default function DirectoryList(props: DirectoryListProps) {
return props.urls.get;
},
get isPaginated() {
return props.paginate !== undefined;
return props.paginate?.itemsPerPage !== undefined;
},
get actions(): TableProps['actions'] {
return [
Expand Down
2 changes: 1 addition & 1 deletion src/sso/connections/ConnectionList/index.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default function ConnectionList(props: ConnectionListProps) {
return props.urls.get;
},
get isPaginated() {
return props.paginate !== undefined;
return props.paginate?.itemsPerPage !== undefined;
},
get colsToDisplay() {
return (props.cols || ['name', 'provider', 'tenant', 'product', 'type', 'status', 'actions']).map(
Expand Down