feat: runner ghcr auth (direct private-image pull) + W3C traceId propagation [A2 4/5]#702
Draft
law-chain-hot wants to merge 1 commit into
Draft
feat: runner ghcr auth (direct private-image pull) + W3C traceId propagation [A2 4/5]#702law-chain-hot wants to merge 1 commit into
law-chain-hot wants to merge 1 commit into
Conversation
…cked on org-membership] Runtime-scoped ghcr auth for direct private-image pull (GHCR_USERNAME/GHCR_TOKEN, env-gated) + W3C traceparent injection api->runner->daemon (one traceId spans the create lifecycle). Go-only, additive. Stacked on PR3. Draft for progress visibility.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 4 of 5 (effort: A2). Stacks on #701. Runner direct-ghcr auth + end-to-end traceId. Go-only, additive. Draft / WIP.
These two changes are what make A2's "box pulls private ghcr directly" possible — the deletion PR (5/5) relies on this runner auth. Incremental diff only (11 files).
Before
After
What Changed
buildImageRegistriesadds aghcr.ioHTTPS + Basic-auth registry entry whenGHCR_USERNAME/GHCR_TOKENare set (env-gated; behavior identical when unset).BOXLITE_TRACEPARENTinto the box env (runner) and seed asandbox.bootspan from it (daemon) so the box joins the API traceId.Next
5/5 (later): delete the
snapshotManagermachinery (registry / backup / build) and collapse the schema tobox_template+runner_artifact_cache(rebuilt clean). Held until the e2e track and thesandbox->boxrename land.