This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Fix inconsistent service name #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the new tld option was introduced, the name of the service became tied to the TLD used. This is screwy, because "dev" is hard-coded as a service name prefix in the boxen ruby gem. We could conceivably add more TLDs to our Dnsmasq setup, but we won't run a separate service for each one. Also, we should stick with the convention observed in other boxen-managed services where the service name is not tied to the configuration of the service.
|
Thanks for this! Past Jacob seems to have ignored the advice given at #17 (comment). |
jacobbednarz
approved these changes
Dec 14, 2017
|
Released in 2.0.5. Much appreciated! 🍰 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the new tld option was introduced (awesome, BTW!), the name of the service became tied to the TLD used. However, "dev" is hard-coded as a service name prefix in the boxen gem. Also, we could conceivably add more TLDs to our Dnsmasq setup, but we won't run a separate service for each one. Lastly, it might be nice to stick with the convention observed in other boxen-managed services where the service name is not tied to the configuration of the service.