Support signatures with PEP 649 deferred annotations#464
Merged
Conversation
d31caa2 to
4425516
Compare
4425516 to
436a4d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #463
Python 3.14 supports deferred annotation loading. However, the
inspect.signatureraises an Error when trying to compute non-existing lazy-loaded annotations (which happens withif TYPE_CHECKINGimports)Instead of:
{orig_name}.__signature__ = _mutmut_signature({mangled_name}__mutmut_orig)we now do:
I think this works in following cases:
inspect.get_annotationsinspect.signatureinspect.get_annotationsinspect.signaturefor eagerly available signaturesinspect.signaturewith deferred annotations (when mutmut cannot eagerly computesignature(...)it now stringifies the signature, which could break some introspection)According to the docs,
get_annotationsis the best practice to read annotations, so I think it's okay that we're not fully supporting theinspect.signaturefor deferred annotations case. I've created #465 for future improvements.