Fix: wasn't selecting the right message when copying/opening url #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting messages and opening or copying, the message that was opened/copied was wrong. There were two separate problems causing this:
try_open_url()andtry_open_file()were not using selected_message(), which was causing the behavior to not match with copying. One of the commits changes those functions to useselected_message().selected_message_id()was iterating over pairs of messages and was sometimes off by one, so there is also a commit that fixes that. Now we iterate over a mix of messages and date headers instead of pairs of messages.Let me know if I missed something or something needs updated!