test: Run integration tests on CI #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2226996240
💛 - Coveralls |
mwwoda
previously approved these changes
Apr 26, 2022
| from boxsdk.client import Client | ||
|
|
||
|
|
||
| def read_jwt_path_from_config(config_path: str): |
There was a problem hiding this comment.
Have you considered supporting .json configuration when running integration tests locally? It may be easier for some developers to download a configuration file and copy it into this particular solution solution, rather than setting an env variable encoded as base64 for the entire machine. For example, our .NET SDK looks for the env variable and, if it is not present, it takes the .json configuration found in the base dir.
mwwoda
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: SDK-2088