feat!: Change some methods signatures to accept keyword only arguments #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszsocha2
force-pushed
the
sdk-1904-fix-liskov-substitution-violations
branch
from
bb1a3c2 to
7160ac8
Compare
Pull Request Test Coverage Report for Build 2798
💛 - Coveralls |
lukaszsocha2
force-pushed
the
sdk-1904-fix-liskov-substitution-violations
branch
from
7160ac8 to
fdb5e0d
Compare
…lations BREAKING CHANGE: Changed function signatures: - get_url() in base_endpoint.py - copy() in 'base_item.py' 'file.py' - create_shared_link() in 'base_item.py', 'item.py' - get_shared_link() in 'base_item.py', 'item.py' - remove_shared_link() in 'base_item.py', 'item.py' - get() in base_object.py, 'item.py' - update_info() in base_object.py, collaboration.py, 'item.py', metadata_template.py - delete() in base_object.py, folder.py, 'item.py', user.py Closes: SDK-1904
lukaszsocha2
force-pushed
the
sdk-1904-fix-liskov-substitution-violations
branch
from
fdb5e0d to
1286eac
Compare
arjankowski
previously approved these changes
Jan 17, 2022
lukaszsocha2
changed the title
lukaszsocha2
changed the title
lukaszsocha2
changed the title
lukaszsocha2
changed the title
lukaszsocha2
changed the title
arjankowski
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Enforcing using keyword only arguments in functions :
copy()inbase_item.pyfile.pycreate_shared_link()initem.py,web_link.pyget_shared_link()initem.py,web_link.pyremove_shared_link()initem.pyget()inbase_object.py,item.pyupdate_info()inbase_object.py,collaboration.py,item.py,metadata_template.pydelete()inbase_object.py,folder.py,item.py,user.pyCloses: SDK-1904