feat: Add vanity_name param for creating shared link to a file or folder
#637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…older Closes: SDK-1815
Pull Request Test Coverage Report for Build 2666
💛 - Coveralls |
mwwoda
reviewed
Nov 26, 2021
| <!-- sample put_folders_id add_shared_link --> | ||
| ```python | ||
| file_id = '11111' | ||
| folder_id = '11111' |
There was a problem hiding this comment.
Why did you replace the file shared link sample with a folder shared link sample?
There was a problem hiding this comment.
Because this is folders.md refering to examples for folder not files. The usage of the creating shared link for file is in files.md line 661.
mwwoda
approved these changes
Nov 26, 2021
lukaszsocha2
deleted the
sdk-1815-add-vanity_name-param-for-shared-links
branch
DaveSawyer
pushed a commit
to DaveSawyer/box-python-sdk
that referenced
this pull request
Dec 4, 2021
…older (box#637) Closes: SDK-1815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: SDK-1815