Skip to content

Conversation

@sohtsuka
Copy link
Contributor

Closes #77.

@boxcla
Copy link

boxcla commented Apr 13, 2015

Verified that @sohtsuka has signed the CLA. Thanks for the pull request!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking documenting this. Can we just rephrase this comment (as well as the others) to say something like:

"Note: the BoxUser.Info returned by this method will only have the ID, name, and login fields populated."

@gcurtis
Copy link
Contributor

gcurtis commented Apr 13, 2015

I've been trying to figure out why updateMembershipSendsCorrectRequestAndParsesResponseCorrectly() is failing. When I run it by itself with:

gradle test --tests *updateMembershipSendsCorrectRequestAndParsesResponseCorrectly

it passes, but when it's run with the other BoxGroupMembership tests, it fails. I'm wondering if this is an issue with WireMock.

If you can't figure what's wrong, then I'm okay with just deleting that test since you also wrote an integration test that covers updating info.

@sohtsuka
Copy link
Contributor Author

Thanks for your comments.
As I mentioned on the pull request #100, I have been getting similar errors since before this commit. All the tests pass if I comment out the following line in BoxAPIRequest.java (line 345):

connection.setFixedLengthStreamingMode((int) this.bodyLength);

but I can't figure out why the errors pop up. I will just delete updateMembershipSendsCorrectRequestAndParsesResponseCorrectly().

@sohtsuka sohtsuka force-pushed the feature/group_memberships branch from ee6a5ea to 5f4cf22 Compare April 14, 2015 14:31
@gcurtis
Copy link
Contributor

gcurtis commented Apr 14, 2015

Thanks for the contribution!

gcurtis added a commit that referenced this pull request Apr 14, 2015
@gcurtis gcurtis merged commit 46b1291 into box:master Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retrieve for a User all his groups

3 participants