Skip to content

chore(deps): Upgrade stylelint from 12 to 16 - #1735

Merged
jackiejou merged 2 commits into
box:masterfrom
jackiejou:chore/upgrade-stylelint-16
Aug 12, 2026
Merged

chore(deps): Upgrade stylelint from 12 to 16#1735
jackiejou merged 2 commits into
box:masterfrom
jackiejou:chore/upgrade-stylelint-16

Conversation

@jackiejou

@jackiejou jackiejou commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Upgrades stylelint from 12 to 16 and aligns the CSS lint stack with box-ui-elements so Preview can keep linting SCSS on current stylelint.

  • Bumps stylelint to ^16.26.1, stylelint-config-standard to ^38, adds stylelint-config-standard-scss ^14, and bumps stylelint-order to ^6
  • Removes dead stylelint-config-rational-order and stops extending the stale @box/frontend@6 stylelint preset
  • Rewrites stylelint.config.js to the standard-scss + order setup used by BUE, including the same pragmatic rule nulls and a class-name pattern that allows digits (mp3, 360, v2)
  • Drops the removed --syntax scss flag from lint-staged
  • Autofixes SCSS for new standard rules (modern rgb() / alpha %, inset, shorthand cleanup)

Why

Matching BUIE package version stylelint 16.

Test plan

  • yarn lint (stylelint + eslint + tsc)
  • pre-push hook: lint + jest --changedSince=upstream/master (no related unit tests)
  • Spot-check Preview load, document overlays, and video controls in Safari for inset / color autofixes

Align packages with box-ui-elements, replace the dead rational-order
config with standard-scss, and autofix SCSS for new stylelint rules.
@jackiejou
jackiejou requested a review from a team as a code owner August 11, 2026 23:10
@socket-security

socket-security Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedstylelint-config-standard-scss@​14.0.01001008285100
Updatedstylelint-order@​3.1.1 ⏵ 6.0.410010094 -383100
Updatedstylelint-config-standard@​19.0.0 ⏵ 38.0.0100100100 +186100
Updatedstylelint@​9.10.1 ⏵ 16.26.196 -110010095 -2100

View full report

Comment thread src/lib/viewers/media/VideoControls.scss
Comment thread src/lib/_common.scss
Comment thread stylelint.config.js
'no-duplicate-selectors': null, // fixme
'selector-no-vendor-prefix': null, // fixme
'property-no-unknown': null, // fixme
'at-rule-no-vendor-prefix': null, // fixme

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's all this fixme

@jackiejou
jackiejou merged commit 65e4cd0 into box:master Aug 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants