-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lots of docs issues, autogen API, switch theme #293
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 68.94% 68.95%
=======================================
Files 15 15
Lines 3214 3215 +1
Branches 792 792
=======================================
+ Hits 2216 2217 +1
Misses 734 734
Partials 264 264
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The build still fails, I'm having a look
I think the failure is because the RTD theme doesn't support the latest sphinx. I'd like to just switch to using the |
Happy to merge it any way, it certainly improves things 👍 |
Now also switches to |
Actually builds on RTD now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @ZedThree!
Also update RTD config to v2 (v1 now doesn't work)