Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GET API #616

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Implement GET API #616

merged 2 commits into from
Dec 18, 2023

Conversation

Bera0422
Copy link
Contributor

Implemented GET methods to

  • return matched annotations according to source URI and creator email
  • return single annotation given its ID

Closes #614

@Bera0422
Implement GET API
60808a1 
Implemented GET methods to
- return matched annotations according to source URI and creator email
- return single annotation given its ID
@Bera0422
Update views.py
51e1900 
Modified to get scheme dynamically
@Bera0422 Bera0422 added priority: medium This issue should be addressed in a reasonable timeframe. size: medium Requires moderate effort and may take several days to a week to complete. difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete type: implementation This issue is related to implementation backend issues related to backend labels Dec 16, 2023
@Bera0422 Bera0422 self-assigned this Dec 16, 2023
@Bera0422
Copy link
Contributor Author

I assumed for URLs etc. They can be modified to be consistent with your implementation. @Simurgan

Simurgan
Simurgan approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@Simurgan Simurgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think URLs are alright and everything implemented as we discussed. Nice 👌

@Simurgan Simurgan merged commit 1ee771b into annotations Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simurgan Simurgan Simurgan approved these changes

Assignees

@Bera0422 Bera0422

Labels
backend issues related to backend difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete priority: medium This issue should be addressed in a reasonable timeframe. size: medium Requires moderate effort and may take several days to a week to complete. type: implementation This issue is related to implementation
Projects
None yet
Milestone
CMPE451 Final Milestone: Presentation...
Development

Successfully merging this pull request may close these issues.
2 participants
@Bera0422 @Simurgan