Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace #610

Merged
merged 6 commits into from
Dec 16, 2023
Merged

Workspace #610

merged 6 commits into from
Dec 16, 2023

Conversation

mehmetSuzer
Copy link
Contributor

Continue #588

Fixed some overflow errors.
Names of the contributors are written line by line now by ListView.builder instead of using '\n'.
Latex is added to mobile and web (preview - write modes)
Entry creation is done by a widget similar to entry card instead of entry popup form. I had difficulty adding scrollable latex to it.
Pending contributors are visible in mobile now.
CardContainer is now background-colorable.

Note: Edit entry is not working for now. I couldnt solve the problem.

@mehmetSuzer mehmetSuzer added priority: high This issue should be addressed as soon as possible. size: medium Requires moderate effort and may take several days to a week to complete. difficulty: challenging Requires advanced skills, knowledge, and may involve complex problems or significant research/collab type: implementation This issue is related to implementation frontend labels Dec 14, 2023
@mehmetSuzer mehmetSuzer self-assigned this Dec 14, 2023
@mehmetSuzer mehmetSuzer mentioned this pull request Dec 14, 2023
Closed
defabdullah
defabdullah reviewed Dec 14, 2023
View reviewed changes
...ience_platform/lib/screens/workspace_page/mobile_workspace_page/widget/contributor_card.dart Outdated
import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';
import '../../../../models/user.dart';
import '../../../../utils/colors.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update this styling. ıt should be similar to package:colloborative_science_platform/...

...ence_platform/lib/screens/workspace_page/mobile_workspace_page/widget/mobile_entry_card.dart Outdated
import 'package:flutter/material.dart';
import 'package:flutter_tex/flutter_tex.dart';

import '../../../../models/workspaces_page/entry.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to my previous comment

...tive_science_platform/lib/screens/workspace_page/mobile_workspace_page/widget/new_entry.dart Outdated
import 'package:flutter/material.dart';
import 'package:flutter_tex/flutter_tex.dart';

import '../../../../utils/colors.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to previous ones

Zulalm
Zulalm requested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@Zulalm Zulalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content of the entries is not shown before clicking write button.
image
Please remove the "name surname (email)" line since we decided to display them only in the node details page in the last lab meeting.

@mehmetSuzer
Copy link
Contributor Author

@Zulalm I don't know the reason of it. It should call the latex renderer when the widget is build, but it does not. I will try to fix it. If I can't, I may start in write mode instead of preview mode.

@mehmetSuzer
Copy link
Contributor Author

@defabdullah @Zulalm import statements are fixed and the latex renderer works in web as well now.

@mehmetSuzer
Copy link
Contributor Author

Now, users can send a message while sending collaboration request.

@mehmetSuzer
Copy link
Contributor Author

I added a semantic tag list view with a search bar to the workspaces. It has mock data for now.
addSemanticTags function takes List on the provider side, but the model of SemanticTags has "String" ids. There is problem that should be fixed.

@Zulalm Zulalm merged commit 80e8174 into frontend Dec 16, 2023
@mehmetSuzer mehmetSuzer deleted the workspace branch December 18, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defabdullah defabdullah defabdullah left review comments

@Zulalm Zulalm Zulalm approved these changes

Assignees

@mehmetSuzer mehmetSuzer

Labels
difficulty: challenging Requires advanced skills, knowledge, and may involve complex problems or significant research/collab frontend priority: high This issue should be addressed as soon as possible. size: medium Requires moderate effort and may take several days to a week to complete. type: implementation This issue is related to implementation
Projects
None yet
Milestone
CMPE451 Final Milestone: Presentation...
Development

Successfully merging this pull request may close these issues.
3 participants
@mehmetSuzer @defabdullah @Zulalm