Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node, Theorem, Proof Model/Classes #302

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Add Node, Theorem, Proof Model/Classes #302

merged 3 commits into from
Oct 22, 2023

Conversation

Bera0422
Copy link
Contributor

Add Node, Theorem and Proof Model/Classes with unit tests. Dependent models of them are also created with no content.

Add Node, Theorem and Proof Model/Classes with unit tests. Dependent models of them are also created with no content.
Remove tests for many to many fields. These should be added after those models are implemented.
@ArslanArdavic ArslanArdavic self-requested a review October 19, 2023 12:55
Copy link
Contributor

@hakanaktas0 hakanaktas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can be merged after the necessary additions are made to Node model

project/backend/database/models.py Show resolved Hide resolved
Updated node references as two lists: from referenced and to referenced with unit tests. Also set related name of proof foreign key to node as "proofs" to access the proof list of a node with that name
@hakanaktas0 hakanaktas0 self-requested a review October 21, 2023 19:04
Copy link
Contributor

@hakanaktas0 hakanaktas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

@gebenalimert gebenalimert self-requested a review October 22, 2023 17:20
Copy link
Contributor

@gebenalimert gebenalimert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All things seems to be working smoothly.

@hakanaktas0 hakanaktas0 merged commit 9a9609c into backend Oct 22, 2023
1 check passed
@Bera0422 Bera0422 deleted the node-branch branch October 28, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proof Class/Model Implementation Theorem Class/Model Implementation Node Class/Model Implementation
3 participants