SerpApi GET Method Implementation #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakanaktas0
added
status: needs-review
size: medium
hakanaktas0
added this to the CMPE352 Practice Application: A Deployed Web Application (Implementation Assignment) milestone
defabdullah
reviewed
May 6, 2023
A different key will be used in deployment.
defabdullah
reviewed
May 6, 2023
mehmetSuzer
approved these changes
May 7, 2023
|
All reviews are completed. I am merging this PR. |
laylaylo
reviewed
May 7, 2023
| # Create your tests here. | ||
| class google_scholar_test_cases(TestCase): |
There was a problem hiding this comment.
Hey, I was just looking at this code again and I noticed that the class naming doesn't quite align with our decision to use PEP-8 Style, see class naming convention. Just a friendly reminder for future reference!
There was a problem hiding this comment.
Thx for the heads up. I will fix them in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the implementation of the GET method that utilizes the SerpApi. It also includes the yaml file of Github Actions for automated testing.
Fixes #112