-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/BE-4 #190
Feature/BE-4 #190
Conversation
BElifb
commented
Oct 23, 2022
•
edited
Loading
edited
- Please clean your database and delete any previous migrations you may have, since extending the AbstractUser will change the whole database schema.
- Created User class by extending AbstractUser, also created Tag, ArtItem and Comment classes.
- Added AUTH_USER_MODEL to settings.py. Also, prefer to create foreign keys to the User model importing the settings from django.conf import settings and referring to the settings.AUTH_USER_MODEL instead of referring directly to the custom User model.
- Installed Pillow package for the media files and updated requirements.txt with the latest additions.
- Configured MEDIA_ROOT in settings.py and added MEDIA folder with default images.
- Created serializers for the models.
- Created a decorator to check whether the user is active_user or not. There are some things to keep in mind here:
- Current redirection path for the decorator is 'login', but we can configure this later as the project structure is more defined.
- is_active and is_active_user are two seperate concepts. First refers to user's account not being blocked (we'll use this when there are complaints about the account and the admin/moderator decides to ban the user), second (is_active_user) refers to user having a level 2 acoount.
- Created and configured the admin site.
- Tested creating users via admin site, fixed media root.
- Please refer to the BE-4: Setting up initial models #187 for further information
|
Looks good to me. Right now, |
I re-configured the settings folder to include both development and production settings. Can I kindly request you to move your (I'm adding this configuration to make sure that everyone starts with the same |
|
LGTM |