Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/questions #141

Merged
merged 4 commits into from
May 20, 2022
Merged

Feature/questions #141

merged 4 commits into from
May 20, 2022

Conversation

BElifb
Copy link
Contributor

@BElifb BElifb commented May 19, 2022 •
edited
Loading

  • Added questions API. Functionality explained in detail here #139
  • Created frontend for questions.
  • Added some error messages to search_by_tag.
  • Added some helpful writing to frontend.
  • Added test for questions API
  • Added some more tests for search_by_tag.
  • Fixed homepage title
  • There shouldn't be too many conflicts, I pulled from origin right before feature/users_frontend merge.

@BElifb BElifb requested review from mumcusena and kostanya May 19, 2022 20:06
@BElifb BElifb mentioned this pull request May 19, 2022
Closed
8 tasks
@simsekhebun simsekhebun merged commit 22f8d9b into practice_app May 20, 2022
@simsekhebun
Copy link
Contributor

Solved the conflicts and merged. Tested the endpoints everything seems fine.

@KarahanS KarahanS deleted the feature/questions branch May 25, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumcusena mumcusena Awaiting requested review from mumcusena

@kostanya kostanya Awaiting requested review from kostanya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BElifb @simsekhebun