Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Html files for users and artitem deletion. #138

Merged
merged 2 commits into from
May 19, 2022
Merged

Html files for users and artitem deletion. #138

merged 2 commits into from
May 19, 2022

Conversation

kostanya
Copy link
Contributor

@kostanya kostanya commented May 19, 2022 •
edited by BElifb
Loading

  • As we need to implement frontend side of our apis, I implemented html files for corresponding endpoints and updated urls and views accordingly.
API API Method API Description
api/v1/artitems/<int:id> DELETE Delete an art item with the given ID
api/v1/users GET Return all of the (non-admin) users
api/v1/users POST Create a user
api/v1/users/<int:id> GET Return a user with the given ID
api/v1/users/<int:id> DELETE Delete a user with the given ID

  • Mentioned html files:

    • delete_artitems_by_id.html
    • add_user.html
    • delete_user_by_id.html
    • get_user_by_id.html
    • list_all_users.html

  • These html files stored in artitem and user folders under templates.

  • For reviewer this PR may require:

  • Testing the related success messages from the interface.
  • Testing the related error messages from the interface.
  • Any kind of typos in the interface.

@kostanya
Added html files for users and artitem deletion.
d917a3e 
Updated urls and views accordingly.
@kostanya kostanya requested a review from sinemKocoglu May 19, 2022 15:52
@kostanya kostanya requested a review from BElifb May 19, 2022 18:26
@BElifb
Copy link
Contributor

BElifb commented May 19, 2022

  • Tested responses and error messages is the interface.
  • No typos detected.
  • Some of the images of users were not visible, considering they were also absent in the media file, I am assuming .media was still in the .gitignore when they were added.
  • Solved conflicts, nothing substential.
  • You did not need to include <!DOCTYPE html>
    <html> sort of things in the html as extending the base already does that for you. But it doesn't seem to cause any errors so I left them as is.
  • Thanks for the effort, everything seems great.

@BElifb BElifb merged commit ebc4adc into practice_app May 19, 2022
@kostanya kostanya mentioned this pull request May 19, 2022
Closed
3 tasks
@KarahanS KarahanS deleted the feature/users_frontend branch May 25, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinemKocoglu sinemKocoglu Awaiting requested review from sinemKocoglu

@BElifb BElifb Awaiting requested review from BElifb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostanya @BElifb