Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search by tag #114

Merged
merged 5 commits into from
May 16, 2022
Merged

Feature/search by tag #114

merged 5 commits into from
May 16, 2022

Conversation

BElifb
Copy link
Contributor

@BElifb BElifb commented May 16, 2022

There are a few main features added with this branch

  1. Implemented search_by_tag API
  2. Implemented a userinterface page that takes tag name, for search_by_tag API
  3. Created template for homepage with links to relevant pages (some links are dummy for now).
  4. Created base template.
  5. All the other templates extend base.
  6. suffix-formatted url patterns.
  7. Urls are arranged in accordance with the new convention.
  8. tests folder is added.
  9. Unittests are added for search_by_tag.
  • You may refer to issues #107, #109, #110, #111 for more detail.
  • You may change the dummy href's with real ones in index.html template for homepage, as you create your own page urls.
  • To use the base template:
    • Add {% extends "main/base.html" %} in the beginning of your template.
    • Add the title inbetween {% block title %} right here {% endblock %} (this is optional).
    • Add the contents of your page inbetween {% block content %} right here {% endblock %} .
    • That's all.
  • To test search_by_tag API run py manage.py test api.
  • About suffix formatted urls:
    • Extend the url with <?format=json> to get json
    • If you're having any trouble with your views, check if you added format=None to the arguments

@kostanya
Copy link
Contributor

HTML templates look simple and useful which is a feature we definitely want for our API project. As far as I could check and test, the search_by_tag feature also works. However, response messages could be more descriptive. Finally, thanks for the clear explanation and the effort.

@kostanya kostanya merged commit aa9f363 into practice_app May 16, 2022
@KarahanS KarahanS added the Approved This work is reviewed and approved by a team member label May 18, 2022
@KarahanS
Copy link
Contributor

Thanks for the review and merging.
After merging I've deleted feature/search_by_tag branch in the remote repository (here in this repo).
If you were working with it on local, you can follow these steps to delete it:
i) Delete the local branch using git branch -d <branch>. branch is the name you used for your local branch. After this step, if you see that remotes/origin/feature/search_by_tag still exists, then do the following.
ii) Delete the remote branch that doesn't have any correspondence in remote repository: git fetch --prune

@KarahanS KarahanS deleted the feature/search_by_tag branch May 18, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This work is reviewed and approved by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants