BM-3087: chore(deployment): staging router deployments (Base Sepolia + Taiko) and upgrade-script reference override#2061
Draft
jonastheis wants to merge 5 commits into
Draft
Conversation
github-actions
Bot
changed the title
jonastheis
changed the title
github-actions
Bot
changed the title
…polia-router-deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Staging deployments of the BoundlessRouter market upgrade from
main@9f2470ab, plus a small upgrade-script extension the Taiko flow required.Base Sepolia staging — deployed, Safe txs pending
Fresh bring-up redone from main; the earlier deployment (router
0x9045fa3c…, impl0xd60e833e…, fromjonas/adopt-router-in-broker@b04705a) was abandoned before the Safe txs executed and its queued upgrade tx has been rejected.[deployment.base-sepolia-staging]:boundless-router→0x6f4523fd85fa19bf469d4f804a55e0d5e73efef4— freshly deployed, Safe holds ADMIN_ROLE from the deploy txboundless-market-impl→0x1de3eacc02f263b666e2251ff6167cecbf51e3b6— new router-aware impl (ROUTER/LEGACY_IMPL/collateral immutables verified on-chain)Two Safe txs are pending: the router bootstrap batch (must execute first) and
upgradeToAndCallon the market proxy. Upgrade guide: https://docs.google.com/document/d/1yNDBqafT9pOgbSfxNRYjPGbU1ZSrIXTMJICeZLED6lo/editTaiko staging — deployed and executed
EOA-admin flow (no Safe), everything built under
FOUNDRY_PROFILE=shanghai. Live on Taiko (chain 167000), verified on-chain:[deployment.taiko-staging]:boundless-router→0xd2a01b63bf9d08d31fb11ba81825624c6484453f— bootstrapped (4 classes, 5 entries); every adapter wraps exactly the verifier the legacy market resolved for its selectorboundless-market-impl→0xad9af87319e744c62f33e05bb2a2cb9f20c7a358— the shanghai-variant router market, upgraded in placeboundless-market-old-impl→0x7d27d73368c9cece5bc25d9b4c9d912de5af9db1— the previous impl, now serving the legacy ABI via the delegatecall fallback (LEGACY_IMPL)Upgrade script: REFERENCE_CONTRACT override
UpgradeBoundlessMarkethardcoded its OZ storage-layout reference tobuild-info-reference:contracts/src/BoundlessMarket.sol:BoundlessMarket, which cannot resolve for the Taiko upgrade: the deployed commit (901097a54) predates the shared-tree shanghai profile, so no reference build exists at that path.New optional
REFERENCE_CONTRACTenv var points the validation at a contract from the current build instead — for Taiko, the frozen legacyBoundlessMarketLegacy.sol:BoundlessMarketundercontracts/shanghai/legacy/, whose bytecode parity with the deployed impl is CI-enforced (just check-legacy-bytecode-shanghai). This keeps the layout safety checks on (noSKIP_SAFETY_CHECKS) with a reference that is provably the deployed code. Default behavior is unchanged when the variable is unset.