BM-3058: fix(cli): list-staking-rewards shows full claimable history#2042
Open
capossele wants to merge 1 commit into
Open
BM-3058: fix(cli): list-staking-rewards shows full claimable history#2042capossele wants to merge 1 commit into
capossele wants to merge 1 commit into
Conversation
capossele
requested review from
a team,
Wollac,
bobbobbio,
jonastheis,
nahoc,
unizarr,
willemolding and
zeroecco
as code owners
June 16, 2026 10:09
willpote
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
boundless rewards list-staking-rewardsunder-reported unclaimed staking rewards because it only looked at a recent window:start_epochdefaulted toend_epoch - 5, so by default only the last 5 epochs were shown.get_reward_delegation_historyfetched only the first page of the indexer's reward-delegation endpoint (default 50 entries, newest-first), so older epochs had no data even when a wider--start-epochwas passed.The claim command (
claim-staking-rewards) was already correct — it scans the full epoch range — so this was a reporting-only bug (no stranded funds), but it could mislead users into thinking they have less to claim.Fix
get_reward_delegation_historynow pages through the entire history instead of the default first page.start_epochdefaults to the address's first participating epoch (from the delegation history) rather thanend − 5.claim-staking-rewardsis unaffected.Follow-up (out of scope)