Skip to content

fix: change space-containing value(s) in Exec key of generated Desktop Entry file… #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirkobrombin merged 1 commit into from
Jan 4, 2026
+3 −2
Merged

fix: change space-containing value(s) in Exec key of generated Desktop Entry file… #4248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bottles/backend/utils/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,12 @@ def create_desktop_entry(
for file in existing_files:
os.remove(file)

# [Bug-]issue #4247 (single- to double-quotes in Desktop Entry spec -> "The Exec key"):
with open(desktop_file, "w") as f:
f.write("[Desktop Entry]\n")
f.write(f"Name={program.get('name')}\n")
f.write(
f"Exec={cmd_cli} run -p {shlex.quote(program.get('name'))} -b '{config.get('Name')}' -- %u\n"
f"Exec={cmd_cli} run -p \"{program.get('name')}\" -b \"{config.get('Name')}\" -- %u\n"
)
f.write("Type=Application\n")
f.write("Terminal=false\n")
Expand All @@ -279,7 +280,7 @@ def create_desktop_entry(
f.write("Actions=Configure;\n")
f.write("[Desktop Action Configure]\n")
f.write("Name=Configure in Bottles\n")
f.write(f"Exec={cmd_legacy} -b '{config.get('Name')}'\n")
f.write(f"Exec={cmd_legacy} -b \"{config.get('Name')}\"\n")

return True
'''
Expand Down