Fail on unsuccessful cab_extract download

[vercingetorx]

Description

The __step_cab_extract method currently returns True even if the download fails. This leads to Bottles showing a dependency as installed when it isn't. This fix adds the needed return logic for such cases.

Fixes #3145

Type of change

• [ x] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Minimal change -> not tested.

[fab-sonarqube]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[github-actions]

Pylint result on modfied files:

************* Module bottles.backend.managers.dependency
bottles/backend/managers/dependency.py:84:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:102:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:113:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:127:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:142:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:159:12: W0105: String statement has no effect (pointless-string-statement)