feat: add --quiet flag to reduce build output #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Why not just allow users to set the log level directly? |
Contributor
Author
|
@swagatbora90 I think the log level can already be controlled. What I really want here is to suppress or dramatically reduce the amount of "informational" stdout printing, which isn't all routed through a logging module. In my mind, the stdout printing is meant for user consumption and the logging is more of a diagnostic output. |
yeazelm
reviewed
Dec 16, 2025
cbgbt
force-pushed
the
quiet-mode
branch
2 times, most recently
from
7471d2b to
104125e
Compare
Add a --quiet/-q flag that suppresses informational messages while preserving warnings and errors. Changes: - Add --quiet flag to CLI arguments - Thread quiet parameter through build and make commands - Conditionally add --quiet to cargo-make invocations - Set TWOLITER_QUIET env var for embedded tools - Adjust pubsys/testsys log levels based on quiet mode - Update init_logger to respect quiet flag In quiet mode: - Suppresses cargo-make INFO messages - Suppresses twoliter INFO logs - Sets embedded tool log levels to warn - Still shows all warnings and errors - Completely silent on successful builds Normal mode behavior is unchanged.
ytsssun
reviewed
Dec 16, 2025
| PUBLISH_REPO = "default" | ||
|
|
||
| PUBLISH_LOG_LEVEL = "info" | ||
| PUBLISH_LOG_LEVEL = { script = ["if [ -n \"${TWOLITER_QUIET}\" ]; then echo warn; else echo info; fi"], condition = { env_not_set = ["PUBLISH_LOG_LEVEL"] } } |
There was a problem hiding this comment.
-n checks if $TWOLITER_QUIET exists. But the implementation sets "1" or "0" for it. Should we check the value here directly instead?
| .env("TWOLITER_QUIET", if global_opts.quiet { "1" } else { "0" }) | ||
| .makefile(makefile_path) | ||
| .project_dir(project.project_dir()) | ||
| .quiet(global_opts.quiet) |
There was a problem hiding this comment.
Q - looking at the code, it seems that the CargoMake.quiet field is not really used? Only the env var was used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a --quiet/-q flag that suppresses informational messages while preserving warnings and errors.
Changes:
In quiet mode:
Normal mode behavior is unchanged.
Testing done:
--quietmodeSee this gist for a before/after comparison.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.